Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Build scripts, Mariner image and latest drivers #7

Merged
merged 7 commits into from
Jun 29, 2023

Conversation

jcamposeco
Copy link
Collaborator

Update Mariner image
Update DOCA/OFED versions
Update latest SOC drivers
Update create bfb scripts

@jcamposeco jcamposeco changed the title Update Build scripts and update Mariner build to latest drivers Update Build scripts, Mariner image and latest drivers Jun 26, 2023
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated
# The Mariner versions of these packages cause build failures. Use only the NVIDIA versions for now
RUN yum install -y --disablerepo="mariner*" perftest libibverbs libreswan
# RUN yum install -y --disablerepo="mariner*" perftest libibverbs libreswan
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove if the Mariner packages are now sufficient :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@@ -159,7 +159,7 @@ GRUB_DEFAULT=saved
GRUB_DISABLE_SUBMENU=true
GRUB_TERMINAL=console
GRUB_SERIAL_COMMAND="serial --unit=1"
GRUB_CMDLINE_LINUX="crashkernel=auto console=hvc0 console=ttyAMA0 earlycon=pl011,0x01000000 modprobe.blacklist=mlx5_core,mlx5_ib"
GRUB_CMDLINE_LINUX="crashkernel=auto console=hvc0 console=ttyAMA0 earlycon=pl011,0x01000000 modprobe.blacklist=mlx5_core,mlx5_ib net.ifnames=0 biosdevname=0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this needed out of curiosity?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change came from Vladimir

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a link to the Mellanox/mariner repo https://github.com/Mellanox/bfb-mariner

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the feedback I got: "we use udev rules to set network interfaces names. Parameters above prevent from other utilities control over network interfaces names"

@@ -257,15 +257,15 @@ copy_rpm()
}

# Copy the content of RPM packages
for package in mlxbf-bfscripts util-linux dosfstools e2fsprogs kmod glibc coreutils pciutils usbutils chkconfig mft mft-oem kernel-mft tar which
for package in mlxbf-bfscripts util-linux dosfstools e2fsprogs kmod glibc coreutils pciutils usbutils chkconfig mft mft-oem kernel-mft tar which curl openssl $ADDON_RPMS
Copy link
Collaborator

@rlmenge rlmenge Jun 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is ADDON_RPMS defined?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is added as an option to add new RPMs is not used as far as i know
Change is also coming from the Nvidia/Mariner repo

@jcamposeco jcamposeco self-assigned this Jun 28, 2023
@jcamposeco jcamposeco merged commit ea1c84a into main Jun 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants