Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Under some specific circumstances test is not detected correctly #2025

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

iserrano76
Copy link
Contributor

Issue:
Under some circumstances the AMSI request in the test is not detected correctly.

Reason:
Avoid false positives.

Fix:
Change the way we do the test request.

Validation:
Test in lab.

@iserrano76 iserrano76 requested a review from a team as a code owner February 27, 2024 10:12
@dpaulson45
Copy link
Member

Please explain why doing it this way avoids the false positives from occurring. It just looks like we are making the URL request stream more complex is all.

@dpaulson45 dpaulson45 merged commit e480d3f into microsoft:main Mar 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants