M1 MPS support #308
Merged
M1 MPS support #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Closed
|
This looks great, and very safe (i.e., very unlikely to have any impact when running on non-M1 HW). I am going to let this sit for a bit until I can find M1 HW to test on, but my expectation is to merge this soon. Thanks! |
|
The more testing the better! I did also check on an Ubuntu system with a GTX 1080 but not a CPU only scenario. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes provide GPU support for Apple M1s once there is a modified version of MDv5. I will add additional details to #297 regarding the fine-tuning steps, which will also allow the modified version of MDv5 to be used with the newest versions of PyTorch for all platforms.