Merge changes from Windows 1809 October Update #5787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dilijev
reviewed
Oct 17, 2018
| @@ -999,52 +1002,52 @@ using namespace Js; | |||
| { | |||
| return FALSE; | |||
| } | |||
| RecyclableObject* object = RecyclableObject::UnsafeFromVar(instance); | |||
| RecyclableObject* object = RecyclableObject::UnsafeFromVar(instance); | |||
There was a problem hiding this comment.
What happened with the indentation here?
dilijev
reviewed
Oct 17, 2018
| { | ||
| PropertyDescriptor desc; | ||
| return GetOwnPropertyDescriptor(object, propertyId, requestContext, &desc); | ||
| } |
There was a problem hiding this comment.
What happened with the indentation here?
| case CacheType_LocalWithoutProperty: | ||
| Assert(!object->HasOwnProperty(propertyId)); | ||
| return FALSE; | ||
| default: |
There was a problem hiding this comment.
Indentation in this file in general looks pretty messed up.
|
I fixed the weird indentation in JavascriptOperators.cpp |
dilijev
reviewed
Oct 18, 2018
dilijev
reviewed
Oct 18, 2018
dilijev
approved these changes
Oct 22, 2018
chakrabot
pushed a commit
that referenced
this pull request
Oct 23, 2018
chakrabot
pushed a commit
that referenced
this pull request
Oct 23, 2018
…tober Update Merge pull request #5787 from Cellule:1809_october
chakrabot
pushed a commit
that referenced
this pull request
Oct 23, 2018
…indows 1809 October Update Merge pull request #5787 from Cellule:1809_october
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is