This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
fix: use query parameter for selected entity and action #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to apply the pattern used on TrainDialogs and LogDialogs here, but it doesn't work.
Something is resetting the location search and I'm not sure how. I tried putting breakpoints on all the
historyoperations and can't isolate it.You can see below the component refreshes with the selectedId set then some time durring the prop updates (sometimes 2th time sometimes 4th) it gets reset.
I thought the whole point if the previous task was to allow refresh and deep linking. It doesn't seem to work even for basic refresh.
Seems there is not much value in committing this at the moment.