Fix incorrect way of checking UI Element names in Data Anonymization page raised in issue #19 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR would fix issue #19 |
sacheinbaala
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Data Anonymization Rules page, TextBox and ComboBox names inside the Scrub Rule panel are created with the logic of appending the ruleIndex value (refer "CreateScrubRule" method).
But while trying to fetch the values of the scrub rule elements ( refer "getScrubRules" method), the logic used for retrieving the element name just takes the substring leaving the last character alone. This would return the expected values only for elements added with single-digit rule index and would result in validation error for elements with ruleIndex greater than 9.