Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing tests for MINIDUMP_TYPE, MiniDumpWriteDump, GetCurrentProcess, GetCurrentProcessId, GetCurrentThreadId. #224

Closed
AraHaan opened this issue Mar 25, 2021 · 1 comment
Closed

Missing tests for MINIDUMP_TYPE, MiniDumpWriteDump, GetCurrentProcess, GetCurrentProcessId, GetCurrentThreadId. #224

AraHaan opened this issue Mar 25, 2021 · 1 comment

Comments

@AraHaan
Copy link
Contributor

AraHaan commented Mar 25, 2021

There may be other apis, however there are missing tests that would check generation on all 3 of the TFMs the tests try to generate for.

If this gets tested it will expose possibly where the issue might be for #221 on these apis. Oddly enough it happens with the enum as well for some unknown reason that I think should generate the enum on .NET Standard 2.0 (but that is another issue for the one I linked) and yes I tried every version of CsWin32 and they all failed the same way on these.
@AraHaan AraHaan mentioned this issue Apr 28, 2021
Closed
@AArnott
Copy link
Member

AArnott commented May 21, 2021

We don't need tests for individual APIs in general. Our FullGeneration test already verifies that no exception is thrown for the whole metadata winmd.
If there are actual failures, or we need to test something specifically, then we add a test to make regression testing faster, since FullGeneration takes a long time to run and produces massive output.
But I see no bugs in any of these APIs. See my comments on your PR.

@AArnott AArnott closed this as completed May 21, 2021
AArnott pushed a commit that referenced this issue Jan 4, 2024
@dependabot
Bump xunit.runner.visualstudio from 2.5.1 to 2.5.3 (#224)
2214ca9 
Bumps [xunit.runner.visualstudio](https://github.com/xunit/visualstudio.xunit) from 2.5.1 to 2.5.3.
- [Release notes](https://github.com/xunit/visualstudio.xunit/releases)
- [Commits](xunit/visualstudio.xunit@2.5.1...2.5.3)

---
updated-dependencies:
- dependency-name: xunit.runner.visualstudio
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@AArnott AArnott mentioned this issue Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added missing tests to kernel32 and DbgHelp. AraHaan/CsWin32
2 participants
@AArnott @AraHaan