Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.Windows.SDK.Win32Docs.dll appears in build and publish output #316

Closed
jnm2 opened this issue Jul 2, 2021 · 1 comment · Fixed by #325
Closed

Microsoft.Windows.SDK.Win32Docs.dll appears in build and publish output #316

jnm2 opened this issue Jul 2, 2021 · 1 comment · Fixed by #325
Assignees
Labels
bug Something isn't working

Comments

@jnm2
Copy link
Contributor

jnm2 commented Jul 2, 2021

Actual behavior

Microsoft.Windows.SDK.Win32Docs.dll is being added as a runtime dependency for the consuming project.

Expected behavior

No Windows SDK .dll files appearing as runtime dependencies.

Repro steps

The only file needed to repro is the .csproj file. This is the package reference metadata created by the NuGet UI, but the problem remains unchanged if you remove the IncludeAssets metadata.

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <TargetFramework>net4.8</TargetFramework>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.Windows.CsWin32" Version="0.1.506-beta">
      <PrivateAssets>all</PrivateAssets>
      <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
    </PackageReference>
  </ItemGroup>

</Project>

Result:

image

@jnm2 jnm2 added the bug Something isn't working label Jul 2, 2021
@AArnott AArnott self-assigned this Jul 11, 2021
@AArnott
Copy link
Member

AArnott commented Jul 11, 2021

Nice catch. Fortunately, an easy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants