Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leverage [Reserved] attributes in metadata to simplify API #840

Closed
AArnott opened this issue Jan 4, 2023 · 0 comments · Fixed by #841
Closed

Leverage [Reserved] attributes in metadata to simplify API #840

AArnott opened this issue Jan 4, 2023 · 0 comments · Fixed by #841
Assignees
@AArnott
Labels
enhancement New feature or request metadata gem A feature of the metadata that cswin32 does not yet utilitze

Comments

@AArnott
Copy link
Member

AArnott commented Jan 4, 2023

The metadata applies the [Reserved] attribute on parameters and fields when the user must use a value of 0 (source).

We can leverage this to omit these parameters from our friendly overloads. We can also declare such fields with private visibility modifiers.
@AArnott AArnott added enhancement New feature or request metadata gem A feature of the metadata that cswin32 does not yet utilitze labels Jan 4, 2023
@AArnott AArnott self-assigned this Jan 5, 2023
AArnott added a commit that referenced this issue Jan 5, 2023
@AArnott
Remove reserved parameters from friendly overloads
ddf2078 
Closes #840
AArnott added a commit that referenced this issue Jan 5, 2023
@AArnott
Remove reserved parameters from friendly overloads
f8afcc1 
Closes #840
@AArnott AArnott mentioned this issue Jan 5, 2023
Merged
AArnott added a commit that referenced this issue Jan 5, 2023
@AArnott
Remove reserved parameters from friendly overloads
a9f8ff6 
Closes #840
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AArnott AArnott

Labels
enhancement New feature or request metadata gem A feature of the metadata that cswin32 does not yet utilitze
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix friendly overload handling of reserved parameters microsoft/CsWin32
1 participant
@AArnott