Add Length property to inline arrays #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnm2
force-pushed
the
inline_array_length_property
branch
from
f926686
to
e8cd8f1
Compare
AArnott
requested changes
Mar 4, 2021
Comment on lines
+3183
to
+3191
| .WithLeadingTrivia(Trivia(DocumentationCommentTrivia(SyntaxKind.SingleLineDocumentationCommentTrivia).AddContent( | ||
| DocCommentStart, | ||
| XmlElement("summary", List(new XmlNodeSyntax[] | ||
| { | ||
| XmlText("Always "), | ||
| XmlElement("c", List(new XmlNodeSyntax[] { XmlText(lengthLiteralSyntax.Token.ValueText) })), | ||
| XmlText("."), | ||
| })), | ||
| DocCommentEnd)))); |
There was a problem hiding this comment.
You might not need the doc comment once we make it a constant, since I think Intellisense will show the constant's value.
Also, the precedent for doc comments is to write it out mostly as a string literal and ask the OM to parse it, since as we see here, this is super-complicated code for a comment.
AArnott
approved these changes
Mar 5, 2021
AArnott
pushed a commit
that referenced
this pull request
Sep 1, 2022
Bumps [Nullable](https://github.com/manuelroemer/Nullable) from 1.3.0 to 1.3.1. - [Release notes](https://github.com/manuelroemer/Nullable/releases) - [Changelog](https://github.com/manuelroemer/Nullable/blob/master/CHANGELOG.md) - [Commits](https://github.com/manuelroemer/Nullable/commits) --- updated-dependencies: - dependency-name: Nullable dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #169