Add SizeParamIndex or CountConst as required to extern methods #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `MarshalAsAttribute` doesn't let us discern between 0 and unset. The C# compiler can tell and sets metadata based on the syntax. We have to lug around `NativeArrayInfo` in order to track a 0 vs. an unset value though till we're ready to emit syntax. Fixes #372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MarshalAsAttributedoesn't let us discern between 0 and unset. The C# compiler can tell and sets metadata based on the syntax. We have to lug aroundNativeArrayInfoin order to track a 0 vs. an unset value though till we're ready to emit syntax.Fixes #372