Add GeneratedCodeAttribute to Generated code

[elachlan]

Closes #594

[ghost]

All CLA requirements met.

[elachlan]

@AArnott If you could give this a quick review that would be great.

[AArnott]

Thanks for contributing. I think you're almost there.

[elachlan]

@AArnott, the remaining test failures are a bit of a strange one. They are all off by one tab space.

If you call AddAttributeLists and then afterwards WithLeadingTrivia, it adds an extra tab space for some reason. I have no idea how to fix it.

[AArnott]

Thank you for getting us this far. I hope to look more into this today or tomorrow.

[elachlan]

@sharwell this code causes the xml comment to have an extra leading tab white space:

typeDeclaration = typeDeclaration
                    .WithLeadingTrivia()
                    .AddAttributeLists(AttributeList().AddAttributes(GeneratedCodeAttribute))
                    .WithLeadingTrivia(typeDeclaration.GetLeadingTrivia());

The generated code attribute is:

private static readonly AttributeSyntax GeneratedCodeAttribute = Attribute(IdentifierName("global::System.CodeDom.Compiler.GeneratedCode"))
        .WithArgumentList(FixTrivia(AttributeArgumentList().AddArguments(
            AttributeArgument(LiteralExpression(SyntaxKind.StringLiteralExpression, Literal(ThisAssembly.AssemblyName))),
            AttributeArgument(LiteralExpression(SyntaxKind.StringLiteralExpression, Literal(ThisAssembly.AssemblyInformationalVersion))))));

It seems like an issue in Roslyn, but its more likely PEBKAC. Is there anything obvious I have missed?

[elachlan]

@AArnott Youssef1313 pointed out in the roslyn issue that the problem is in WhitespaceRewriter. I'll let you know if I manage to solve it.

Edit: It looks like there is an issue in WhitespaceRewriter.VisitList. It seems to think that the XML comment's parent is the attribute and not the class declaration? Nothing else has this issue.

[Youssef1313]

@elachlan Can you see if elachlan#1 fixes the issue?

[elachlan]

I'll pull yours down now and check it.

[elachlan]

@Youssef1313 I have pushed through some more changes around for loop indenting.

This is what its generating at the moment inside PAINTSTRUCT

I am not 100% sure, but there might be braces missing.

Edit: it might actually just be single line.

[elachlan]

I gave up on the for loops.

I have fixed the other test issues. We can fix the rest of the white space issues in another PR.

[elachlan]

@AArnott can you give this another review?

[elachlan]

@Youssef1313 thank you for your help on this! It helped immensely.

[AArnott]

Thank you for your contribution. I would never have guessed this required so much work. I appreciate your dedication.