Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Observe DangerousAddRef result before proceeding." #765

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Revert "Observe DangerousAddRef result before proceeding." #765

merged 1 commit into from
Nov 11, 2022

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Nov 11, 2022

Reverts #762

Per @AaronRobinsonMSFT, this isn't necessary because DangerousAddRef will throw rather than return having set the ref parameter to false.

@AArnott AArnott merged commit 6abc778 into main Nov 11, 2022
@AArnott AArnott deleted the revert-762-fix754 branch November 11, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@AArnott