Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf enhancements #782

Merged
merged 3 commits into from
Nov 16, 2022
Merged

Perf enhancements #782

merged 3 commits into from
Nov 16, 2022

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Nov 16, 2022

  • Turn off API docs generation in most tests.
  • Avoid mutating SyntaxList in a loop. This was the single worst source of bad perf in the FullGeneration test, costing 20 seconds out of 1.9 minutes.
  • Add cache for slow FindTypeSymbolIfAlreadyAvailable method.

@AArnott
Add cache for slow FindTypeSymbolIfAlreadyAvailable method
96a57d4
@AArnott
Avoid mutating SyntaxList in a loop
dc039a7 
This was the single worst source of bad perf in the FullGeneration test, costing 20 seconds out of 1.9 minutes.
@AArnott
Turn off API docs generation in most tests
a178b39 
This was greatly increasing test run time.
@AArnott AArnott merged commit 6ae12d1 into main Nov 16, 2022
@AArnott AArnott deleted the perfWork branch November 16, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@AArnott