Skip to content

Commit

Permalink
Move up to WinUI 3 Preview 3, remove workarounds in sample, centraliz…
Browse files Browse the repository at this point in the history
…e SDK version (#625)

* move build up to WinUI 3 Preview 3, remove workarounds in sample, centralize SDK version

* PR feedback
  • Loading branch information
Scottj1s committed Dec 8, 2020
1 parent bd1fd97 commit fa3b39e
Show file tree
Hide file tree
Showing 9 changed files with 1,225 additions and 2,302 deletions.
Expand Up @@ -23,7 +23,6 @@
<ProjectGuid>{0212a7c5-8d3f-443c-9ebc-1f28091fdf88}</ProjectGuid>
<Keyword>Win32Proj</Keyword>
<RootNamespace>AuthoringConsumptionTest</RootNamespace>
<WindowsTargetPlatformVersion>10.0.19592.0</WindowsTargetPlatformVersion>
<ConfigurationType>Application</ConfigurationType>
<PlatformToolset>v142</PlatformToolset>
<CharacterSet>Unicode</CharacterSet>
Expand Down
1 change: 0 additions & 1 deletion src/Authoring/WinRT.Host/WinRT.Host.vcxproj
Expand Up @@ -24,7 +24,6 @@
<Keyword>Win32Proj</Keyword>
<ProjectGuid>{7e33bcb7-19c5-4061-981d-ba695322708a}</ProjectGuid>
<RootNamespace>WinRTHost</RootNamespace>
<WindowsTargetPlatformVersion>10.0</WindowsTargetPlatformVersion>
</PropertyGroup>
<Import Project="$(VCTargetsPath)\Microsoft.Cpp.Default.props" />
<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|Win32'" Label="Configuration">
Expand Down
2 changes: 1 addition & 1 deletion src/Directory.Build.props
Expand Up @@ -8,7 +8,7 @@
<CppWinRTVerbosity>high</CppWinRTVerbosity>
<CsWinRTVerbosity>high</CsWinRTVerbosity>
<!--Note: unlisted at https://www.nuget.org/packages/Microsoft.WinUI/-->
<MicrosoftWinUIVersion>3.0.0-preview2.200713.0</MicrosoftWinUIVersion>
<MicrosoftWinUIVersion>3.0.0-preview3.201113.0</MicrosoftWinUIVersion>
<DebugType>full</DebugType>
<DebugSymbols>true</DebugSymbols>
<LangVersion>preview</LangVersion>
Expand Down
78 changes: 0 additions & 78 deletions src/Samples/WinUIDesktopSample/Net5_WinUI_Fixup.Targets

This file was deleted.

3 changes: 1 addition & 2 deletions src/Samples/WinUIDesktopSample/WinUIDesktopSample.csproj
Expand Up @@ -2,7 +2,7 @@

<PropertyGroup>
<OutputType>WinExe</OutputType>
<TargetFramework>net5.0</TargetFramework>
<TargetFramework>net5.0-windows10.0.19041.0</TargetFramework>
<DefineConstants>DISABLE_XAML_GENERATED_MAIN</DefineConstants>
<ApplicationManifest>WinUIDesktopSample.exe.manifest</ApplicationManifest>
<!--
Expand All @@ -11,7 +11,6 @@
-->
<XamlCodeGenerationControlFlags>DoNotGenerateOtherProviders</XamlCodeGenerationControlFlags>
<Platforms>x86;x64</Platforms>
<MsAppxPackageTargets>$(MSBuildThisFileDirectory)Net5_WinUI_Fixup.Targets</MsAppxPackageTargets>
</PropertyGroup>

<ItemGroup>
Expand Down

0 comments on commit fa3b39e

Please sign in to comment.