Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing couple reported issues #1604

Merged
merged 17 commits into from
May 10, 2024
Merged

Conversation

manodasanW
Copy link
Member

@manodasanW manodasanW commented May 8, 2024

  • Incrementing the assembly version to reflect what it should actually be
  • Fixing AsAsyncOperation and similar async scenarios where we weren't previously generating the vtable for generic classes implementing generic WinRT interfaces. We still don't do that in general, but at least the async scenarios are now handled by using the global vtable lookup table when we detect such a function being used.
  • Adding property to be able to control whether the global vtable lookup table generation happens. This is by default disabled if we detect that you are trying to generate a projection as we don't need global vtable lookup table for those scenarios. Otherwise, it is by default enabled.
  • Fixing issue where when we were asked to generate the vtable for a boxed struct, we were failing to because we were restricting checking the CCW type to classes.
  • Fixing issue where when using foreach, it was possible for an element to be get added to the list and thereby that would fail due to change in collection while doing for each. Given we never remove from the list and only add, replacing it with a normal loop where we check count before looping. Also doing it for the other scenarios where we were doing similar checks given those were running into a writer lock being taken while a reader lock was held.
  • Fixing issue where both the component generator and the AOT generator were generating the same generic interface instantiation static classes. We now detect that the component generator would have generated that and don't do it in the AOT generator. This issue started showing up after fixing the issue where our collection adapter classes weren't generated for the non authoring scenarios even though we probably should.

Fixes #1584

@manodasanW manodasanW marked this pull request as ready for review May 8, 2024 20:32
@manodasanW manodasanW requested a review from Sergio0694 May 8, 2024 20:32
@manodasanW manodasanW merged commit 6bf1a64 into staging/AOT May 10, 2024
10 checks passed
@manodasanW manodasanW deleted the manodasanw/globalvtableLookup branch May 10, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants