Fix broken links documentation #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodasanW
reviewed
Dec 5, 2020
docs/interop.md
Outdated
| @@ -98,7 +98,7 @@ SetString(MarshalString.GetAbi(marshalStr)); | |||
| **Note:** The CLR still supports marshaling COM (IUnknown), but not WinRT (IInspectable), interop interfaces. There are two approaches to marshaling IInspectable interfaces in C#/WinRT. | |||
|
|
|||
| ##### Projected | |||
| If possible, the interop interface should be defined in IDL and a C#/WinRT projection produced for it. This automatically generates all marshaling logic so that calling code can pass and receive projected types. For an example of this, see the [IUserConsentVerifierInterop definition](https://github.com/microsoft/CsWinRT/blob/master/TestComponentCSharp/TestComponentCSharp.idl#L356) and [related test code](https://github.com/microsoft/CsWinRT/blob/master/UnitTest/TestComponentCSharp_Tests.cs#L1039). | |||
| If possible, the interop interface should be defined in IDL and a C#/WinRT projection produced for it. This automatically generates all marshaling logic so that calling code can pass and receive projected types. For an example of this, see the [IUserConsentVerifierInterop definition](https://github.com/microsoft/CsWinRT/blob/master/src/Tests/TestComponentCSharp/TestComponentCSharp.idl#L360) and [related test code](https://github.com/microsoft/CsWinRT/blob/master/src/Tests/UnitTest/TestComponentCSharp_Tests.cs#L1092). | |||
There was a problem hiding this comment.
Those line numbers are probably going to change often, maybe we should make a copy of the example here rather than references.
There was a problem hiding this comment.
yeah you're right, just made an update
manodasanW
approved these changes
Dec 5, 2020
angelazhangmsft
approved these changes
Dec 5, 2020
Scottj1s
reviewed
Dec 7, 2020
Scottj1s
reviewed
Dec 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the codebase restructure, a couple links in the interop.md got broken. I believe I pointed them to where they were originally pointing to. @Scottj1s can you confirm these links are going to the right examples?
Going to comb through the rest of our docs and fix any others I see.