Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something wrong with the node's last owned time and last reimaged time? #95

Closed
TTDietCoke opened this issue Dec 6, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@TTDietCoke
Copy link

Sorry to bother.

I am wondering if class NodeTrackingInformation is not indicating the right occurrence time of the last attack?

The time() func at line 248 and 671 in actions.py would set the nodes's last_reimaging_time and last_owned time to be '00:00:00'. So when the cyber attacker attempts to re-connect to a conquered but lately reimaged node, func __is_node_owned_history at line 483 would recognize the reimaged node as a currently owned node. Therefore the cyber attacker can never connect to a reimaged node successfully.

Is it true, or am I mistaking something here😂?

@TTDietCoke TTDietCoke changed the title Something wrong with defender's REIMAGE func? Something wrong with the node's last owned time and last reimaged time? Dec 6, 2022
@blumu blumu added question Further information is requested bug Something isn't working and removed question Further information is requested labels Oct 13, 2023
@blumu
Copy link
Contributor

blumu commented Oct 13, 2023

Thanks for reporting. That's a bug where the action.py file imports the time module with from datetime import time instead of importing the time function using from time import time. Testing a fix, will submit a PR soon

blumu pushed a commit that referenced this issue Oct 13, 2023
@blumu blumu self-assigned this Oct 13, 2023
blumu pushed a commit that referenced this issue Oct 13, 2023
blumu added a commit that referenced this issue Oct 13, 2023
…rning the NULL time. #95 (#114)

Upgrade pyright

Co-authored-by: William Blum <william.blum@microsoft.com>
@blumu blumu closed this as completed Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants