Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: Upgrade use-http to 0.1.91 ... #560

Merged
merged 1 commit into from Oct 17, 2019

Conversation

Gerhut
Copy link
Member

@Gerhut Gerhut commented Oct 15, 2019

and remove deprecated methods.

Closes #553

Kindly ping @LeoHongyi for a code review, tested locally.

P.S. @alex-cory I found that each time the returned { get }-liked methods are different and hard to be listed as dependencies (or it will cause useEffect runs in every render), is it by design or my incorrect use?

and remove deperated methods.
@alex-cory
Copy link

@Gerhut That sounds like it might be a bug. 🤔I will look into this. I have an idea of what might be causing this. I'll add an issue and get it fixed asap. Thanks for reporting this! 😊

@hongzhili hongzhili merged commit af41cbf into microsoft:dltsdev Oct 17, 2019
@Gerhut Gerhut deleted the dashboard/use-http-migration branch November 14, 2019 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants