New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checks for user injection policy #3052
Conversation
Hey @lekurile, |
Hey @lekurile, Thanks for checking, but I somehow can't find your review. As I understand you are suggesting to move the function out. Will make changes. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@satpalsr Can you please run pre-commit
as well to resolve formatting issues?
https://github.com/microsoft/DeepSpeed/blob/master/CONTRIBUTING.md#prerequisites
I see formatting failing. Though there's no formatting issues in my changes. I see issue in general_kernals.cu |
Hi @satpalsr, Apologies for the delayed response. I think we'd still like to merge this change, but it would be nice to merge the latest master and rerun tests again. I'll take another look at the formatting issues as well. Thanks, |
This PR introduces check for user injection policy arguments.
Right now, below code executes without any error/warning even though user injection policy is not used.
This PR enforces correct usage of injection_policy with necessary checks.