Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goodbye Torch 1.8 #3082

Merged
merged 7 commits into from Mar 23, 2023
Merged

Goodbye Torch 1.8 #3082

merged 7 commits into from Mar 23, 2023

Conversation

mrwyattii
Copy link
Contributor

Following HF (huggingface/transformers#22291) in dropping support for older versions of torch

@ydshieh ydshieh mentioned this pull request Mar 22, 2023
Merged
5 tasks
@stas00 stas00 mentioned this pull request Mar 23, 2023
Merged
@stas00
Copy link
Contributor

stas00 commented Mar 23, 2023

huggingface/transformers#22325 has been merged so it should work again.

@satpalsr
Copy link
Contributor

Hey @tjruwase @jeffra
When to expect for approved PRs to start getting merged?

@jeffra
Copy link
Contributor

jeffra commented Mar 23, 2023

Hey @tjruwase @jeffra When to expect for approved PRs to start getting merged?

Hi @satpalsr, we're currently making our way through the backlog after a bunch of recent CI related issues. I think those are all now addressed (🤞). Are there specific PRs you're waiting for that we can help prioritize?

@mrwyattii mrwyattii merged commit 5cdf359 into microsoft:master Mar 23, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffra jeffra jeffra approved these changes

@tjruwase tjruwase tjruwase approved these changes

@loadams loadams loadams approved these changes

@RezaYazdaniAminabadi RezaYazdaniAminabadi Awaiting requested review from RezaYazdaniAminabadi

@awan-10 awan-10 Awaiting requested review from awan-10 awan-10 is a code owner

@cmikeh2 cmikeh2 Awaiting requested review from cmikeh2

@arashb arashb Awaiting requested review from arashb arashb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mrwyattii @stas00 @satpalsr @jeffra @tjruwase @loadams