fixing default communication_data_type for bfloat16_enabled and docs #3370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2071
#2145 fixed the case when
communication_data_type
is set explicitly, unfortunately the default value for whenbfloat16_enabled=True
is notbfp16
.Adding unit tests for default
communication_data_type
.Correcting the docs that mentioned
communication_data_type
as being of typeboolean
.Before the fix:
After the fix: