Correct world_size/backend for mpi #3694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abhilash1910 - can you show that this is correct now? Just checking there was no reason these were flipped for non-MPI or anything. |
mrwyattii
approved these changes
Jun 6, 2023
loadams
approved these changes
Jun 6, 2023
molly-smith
pushed a commit
that referenced
this pull request
Jun 23, 2023
Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the PR:
Currently when using mpi , the arguements for world_size and rank from the Backend constructor is appearing incorrectly.
The rank and size are misplaced while running mpi .
@tjruwase @awan-10 can you please take a look ?
PS: CLA is signed