Small tweak on cuda version mismatch documentation #3706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loadams
reviewed
Jun 7, 2023
mrwyattii
approved these changes
Jun 7, 2023
loadams
approved these changes
Jun 7, 2023
molly-smith
pushed a commit
that referenced
this pull request
Jun 23, 2023
* Small tweak on cuda version mismatch documentation * clarify minor versions should also match --------- Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current text at https://www.deepspeed.ai/tutorials/advanced-install/#cuda-version-mismatch was confusing to me:
The word "however" made me wonder if there was a typo, and the sentence was supposed to say that even minor version differences could result in unexpected behavior.
But based on the messages in
assert_no_cuda_mismatch, my guess is that minor version differences are fine, and the sentence was just a bit unclear.