Fix output transpose dimension bugs #3747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loadams
requested review from
RezaYazdaniAminabadi,
awan-10,
jeffra,
cmikeh2 and
arashb
as code owners
This was referenced Jun 13, 2023
RezaYazdaniAminabadi
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge two fixes together to the same file, two bugs identified in the output dim of vector matmul transpose.
Original fixes: #3668 and #3602
Co-authored-by: alchemy_tao hellozhaojian@users.noreply.github.com
Co-authored-by: LiYu Lu luliyucoordinate@users.noreply.github.com