add option to disable pipeline partitioning #4322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelyahu
requested review from
ShadenSmith,
duli2012,
jeffra and
tjruwase
as code owners
|
@ShadenSmith @jeffra @duli2012 @tjruwase - can you please review? |
|
@tjruwase Hi :) can someone help reviewing this change? |
tjruwase
reviewed
Oct 4, 2023
nelyahu
force-pushed
the
disable_pipeline_partitioning
branch
from
c5f497e
to
85ee4ac
Compare
added pipeline configuration to deepspeed config under pipeline section, with defaults of pipe_partitioned = True grad_partitioned = True can be used to enable or disable activations and grads partitioning in TP/PP mode. When not using TP, activation and grads partitioning will be disabled regardless of this confgiuration.
nelyahu
force-pushed
the
disable_pipeline_partitioning
branch
from
85ee4ac
to
0885438
Compare
tjruwase
approved these changes
Oct 9, 2023
loadams
approved these changes
Oct 18, 2023
|
@tjruwase - should we add this to any docs we have? |
mauryaavinash95
pushed a commit
to mauryaavinash95/DeepSpeed
that referenced
this pull request
Feb 17, 2024
added pipeline configuration to deepspeed config under pipeline section pipe_partitioned = "auto" grad_partitioned = "auto" can be used to enable or disable activations and grads partitioning in TP/PP mode Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com> Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added pipeline configuration to deepspeed config under pipeline section pipe_partitioned = "auto"
grad_partitioned = "auto"
can be used to enable or disable activations and grads partitioning in TP/PP mode