Change default set_to_none=true in zero_grad methods
#4438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jackmin801
requested review from
jeffra,
tjruwase,
samyam and
mrwyattii
as code owners
|
Should I go around the code changing all the |
tjruwase
approved these changes
Oct 3, 2023
@Jackmin801, thanks for the PR. Yes, it is okay to leave the existing calls as is. |
mauryaavinash95
pushed a commit
to mauryaavinash95/DeepSpeed
that referenced
this pull request
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default was changed to
falsein this PR with the intention of matching PyTorch#2741
However, since then, PyTorch has changed their default to
true.https://pytorch.org/docs/stable/_modules/torch/optim/optimizer.html#Optimizer.zero_grad
pytorch/pytorch#92731