Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix error type issue in deepspeed/comm/ccl.py #4521

Merged
merged 2 commits into from
Oct 18, 2023
Merged

fix error type issue in deepspeed/comm/ccl.py #4521

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
047e95c
fix error type in ccl.py
Liangliang-Ma Oct 17, 2023
2821251
Merge branch 'master' into cclbackend
loadams Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion deepspeed/comm/ccl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ def get_all_ranks_from_group(self, group):
while True:
results.append(super(CCLBackend, self).get_global_rank(group, rank))
rank += 1
except RuntimeError:
except ValueError:
pass
if tuple(results) not in self.groups:
self._new_group(results, group)
Expand Down