universal-ckp: support megatron-deepspeed llama model #4666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megatron-DeepSpeed's llama implementation of swiglu allocates a single ColumnParallelLinear layer L, but effectively this parameter is a container of two Linear layers L1, L2 used for silu(L1(x)) * L2(x)). This requires special handling in ds_to_universal to create a representation of L parameter where the slices of L1 and L2 are first concatenated and then L is created by concatenating L1 and L2. Signed-off-by: Moshe Island <misland@habana.ai>
tjruwase
approved these changes
Nov 14, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mauryaavinash95
pushed a commit
to mauryaavinash95/DeepSpeed
that referenced
this pull request
Feb 17, 2024
Megatron-DeepSpeed's llama implementation of swiglu allocates a single ColumnParallelLinear layer L, but effectively this parameter is a container of two Linear layers L1, L2 used for silu(L1(x)) * L2(x)). This requires special handling in ds_to_universal to create a representation of L parameter where the slices of L1 and L2 are first concatenated and then L is created by concatenating L1 and L2. Signed-off-by: Moshe Island <misland@habana.ai> Co-authored-by: Moshe Island <misland@habana.ai> Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com> Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Megatron-DeepSpeed's llama implementation of swiglu allocates a single ColumnParallelLinear layer L, but effectively this parameter is a container of two Linear layers L1, L2 used for silu(L1(x)) * L2(x)). This requires special handling in ds_to_universal to create a representation of L parameter where the slices of L1 and L2 are first concatenated and then L is created by concatenating L1 and L2.