Delete unused --deepspeed_mpi command line argument #4981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed this argument in my command-line arguments being added by DeepSpeed, and turns out it being False by default has no effect. Since it is not used anywhere, it's probably best to delete it.
ShukantPal
force-pushed
the
shukant/delete-deepspeed_mpi-option
branch
from
c2b1e29
to
cece5ab
Compare
mrwyattii
approved these changes
Jan 23, 2024
mauryaavinash95
pushed a commit
to mauryaavinash95/DeepSpeed
that referenced
this pull request
Feb 17, 2024
I noticed this argument in my command-line arguments being added by DeepSpeed, and turns out it being False by default has no effect. Since it is not used anywhere, it's probably best to delete it. Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
rraminen
pushed a commit
to ROCm/DeepSpeed
that referenced
this pull request
May 9, 2024
I noticed this argument in my command-line arguments being added by DeepSpeed, and turns out it being False by default has no effect. Since it is not used anywhere, it's probably best to delete it. Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this argument in my command-line arguments being added by DeepSpeed, and turns out it being False by default has no effect. Since it is not used anywhere, it's probably best to delete it.