[minor] Improve logging for multiprocesses #5004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByronHsu
requested review from
mrwyattii,
tjruwase and
awan-10
as code owners
Signed-off-by: byhsu <byhsu@linkedin.com>
ByronHsu
force-pushed
the
byhsu/improve-logging-with-pid
branch
from
f96040c
to
787feda
Compare
Signed-off-by: byhsu <byhsu@linkedin.com>
ByronHsu
changed the title
|
HI @mrwyattii @jeffra could you help taking a quick look? Thanks a lot |
HeyangQin
approved these changes
Jan 26, 2024
mauryaavinash95
pushed a commit
to mauryaavinash95/DeepSpeed
that referenced
this pull request
Feb 17, 2024
**Why?** 1. When the launcher starts multi-processes, there is no logs to show what cmd each process is running 2. A small typo **What?** add logs to reflect what each process is doing **Testing**  --------- Signed-off-by: byhsu <byhsu@linkedin.com> Co-authored-by: byhsu <byhsu@linkedin.com>
rraminen
pushed a commit
to ROCm/DeepSpeed
that referenced
this pull request
May 9, 2024
**Why?** 1. When the launcher starts multi-processes, there is no logs to show what cmd each process is running 2. A small typo **What?** add logs to reflect what each process is doing **Testing**  --------- Signed-off-by: byhsu <byhsu@linkedin.com> Co-authored-by: byhsu <byhsu@linkedin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
What?
add logs to reflect what each process is doing
Testing