Further refactor deepspeed.moe.utils + deepspeed.moe.layer type hints #5060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in dict unpacking, keys after an unpacking overwrite keys of the unpacked dict, meaning we can avoid avoid the pattern of skipping certain keys; also use defaultdict to avoid having to do the boilerplate of assigning the elements of group_moe
mrwyattii
approved these changes
Feb 2, 2024
Co-authored-by: Michael Wyatt <mrwyattii@gmail.com>
|
@ringohoffman could you please run formatting on this branch? |
…to_different_moe_groups_for_optimizer
…nt_moe_groups_for_optimizer
mauryaavinash95
pushed a commit
to mauryaavinash95/DeepSpeed
that referenced
this pull request
Feb 17, 2024
…microsoft#5060) When unpacking a `dict`, keys that appear after the unpacking can overwrite the keys of the unpacked `dict`, meaning we can avoid avoid the pattern of skipping certain keys; also use `defaultdict` to avoid having to do the boilerplate of assigning the elements of `group_moe`. More type hints and small stylistic changes to `deepspeed.moe.layer` --------- Co-authored-by: Michael Wyatt <mrwyattii@gmail.com> Co-authored-by: Michael Wyatt <michaelwyatt@microsoft.com>
rraminen
pushed a commit
to ROCm/DeepSpeed
that referenced
this pull request
May 9, 2024
…microsoft#5060) When unpacking a `dict`, keys that appear after the unpacking can overwrite the keys of the unpacked `dict`, meaning we can avoid avoid the pattern of skipping certain keys; also use `defaultdict` to avoid having to do the boilerplate of assigning the elements of `group_moe`. More type hints and small stylistic changes to `deepspeed.moe.layer` --------- Co-authored-by: Michael Wyatt <mrwyattii@gmail.com> Co-authored-by: Michael Wyatt <michaelwyatt@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unpacking a
dict, keys that appear after the unpacking can overwrite the keys of the unpackeddict, meaning we can avoid avoid the pattern of skipping certain keys; also usedefaultdictto avoid having to do the boilerplate of assigning the elements ofgroup_moe.More type hints and small stylistic changes to
deepspeed.moe.layer