set the default to use set_to_none for clearing gradients in BF16 optimizer. #5434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjruwase
reviewed
Apr 19, 2024
deepspeed/runtime/bf16_optimizer.py
Outdated
| @@ -441,11 +441,20 @@ def clear_hp_grads(self): | |||
| self.fp32_groups_has_gradients[i] = [False] * len(group) | |||
|
|
|||
| def clear_lp_grads(self): | |||
|
|
|||
| # using zero_() fixed memory address for graph replay | |||
| set_to_none = set_to_none = False if self.graph_harvesting else True | |||
There was a problem hiding this comment.
Suggested change
| set_to_none = set_to_none = False if self.graph_harvesting else True | |
| set_to_none = False if self.graph_harvesting else True |
There was a problem hiding this comment.
fixed and reverified
tjruwase
reviewed
Apr 20, 2024
tjruwase
approved these changes
Apr 22, 2024
rraminen
pushed a commit
to ROCm/DeepSpeed
that referenced
this pull request
May 9, 2024
…imizer. (microsoft#5434) as discussed in microsoft#5175, set the default to use set_to_none for clearing gradients in BF16 optimizer. Additionally, for the case of zero clearing, use foreach_zero. Verified correctness with mega-ds llama 7B training. FYI @loadams --------- Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
umchand
pushed a commit
to umchand/DeepSpeed
that referenced
this pull request
May 20, 2024
…imizer. (microsoft#5434) as discussed in microsoft#5175, set the default to use set_to_none for clearing gradients in BF16 optimizer. Additionally, for the case of zero clearing, use foreach_zero. Verified correctness with mega-ds llama 7B training. FYI @loadams --------- Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in #5175, set the default to use set_to_none for clearing gradients in BF16 optimizer.
Additionally, for the case of zero clearing, use foreach_zero.
Verified correctness with mega-ds llama 7B training.
FYI @loadams