Fix memory leak from _hp_mapping #5643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiragjn
force-pushed
the
fix-memory-leak
branch
from
0866580
to
f706f51
Compare
loadams
reviewed
Jun 17, 2024
tjruwase
approved these changes
Jun 18, 2024
chiragjn
force-pushed
the
fix-memory-leak
branch
from
1372f3d
to
f3738e4
Compare
chiragjn
force-pushed
the
fix-memory-leak
branch
from
abc13bf
to
51784eb
Compare
|
Apologies, I had made some mistakes in bf16 optimizer and couldn't get to fixing them sooner, I should have tested things locally 😅 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 24, 2024
See #5496 I don't really know if this is a good solution
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 25, 2024
See #5496 I don't really know if this is a good solution
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5496
I don't really know if this is a good solution