Update tar dependency #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sandersn
requested changes
May 3, 2022
There was a problem hiding this comment.
Looks good although I have a question about yarn.lock
@sheetalkamat is on DT this week, so I want to let her know before merging this, just in case it causes problems.
| @@ -8049,7 +8018,7 @@ tar@^4.4.12: | |||
| safe-buffer "^5.1.2" | |||
| yallist "^3.0.3" | |||
|
|
|||
| tar@^6.0.2, tar@^6.1.0: | |||
| tar@^6.0.2, tar@^6.1.0, tar@^6.1.11: | |||
There was a problem hiding this comment.
Why are the old versions of tar still in yarn.lock?
There was a problem hiding this comment.
These are transitive dependencies (@lerna/pack-directory depends on ^6.1.0, node-gyp on ^6.0.2, etc.)
sandersn
approved these changes
May 4, 2022
|
Actually, tar failures won't make dts-critic fail CI, and it'll show up in the overnight build. I'll be notified tomorrow if there are problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the old
tardependency to the latest version and used its new API.The
@types/tarpackage seems to be incorrect (it shows the old API), so I decided to remove it completely. As thetarpackage is used in just one place, I think it's not a big deal to use the untyped library.I haven't been able to definitely verify if setting directory permissions still works. 7Zip on Windows shows full permissions on the packed directory, but I haven't checked it on Linux yet.
Closes #347