-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cached npm info #451
Merged
Merged
Use cached npm info #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jablko
commented
May 5, 2022
- In generate-packages we know the npm info was cached in calculate-versions, so we don't consult the origin (npm registry) --- except in this one case, so fix that case (replace fetchAndCacheNpmInfo() with getNpmInfoFromCache()).
- Add some static checks that we're not going to the origin, except in calculate-versions.
- Don't bother writing the cache if there's no way we could have gone to the origin (correct but inconsequential optimization).
jablko
force-pushed
the
patch-48
branch
2 times, most recently
from
May 8, 2022 19:46
50afb55
to
ffda973
Compare
jablko
force-pushed
the
patch-48
branch
3 times, most recently
from
May 16, 2022 15:09
999ea2d
to
74a5653
Compare
I've rebased this on #456 and replaced The advantages over
|
jablko
force-pushed
the
patch-48
branch
5 times, most recently
from
May 21, 2022 18:51
1e74144
to
2a8c8a3
Compare
This was referenced May 22, 2022
jablko
force-pushed
the
patch-48
branch
3 times, most recently
from
May 30, 2022 16:13
e850fcc
to
b7dd694
Compare
Merged
andrewbranch
added a commit
that referenced
this pull request
Jun 9, 2022
This reverts commit e246b08.
andrewbranch
added a commit
that referenced
this pull request
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.