New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove TSLint #866
feat: remove TSLint #866
Conversation
Also todo:
|
There's one reference left to tslint in packages/dtslint/README.md. |
CI still fails from knip, but we're close. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, although it also needs a matching DT PR to remove tslint.jsons there, and a pnpm changeset
entry.
I have no idea how this didn't fail the changeset test. |
Right, the existing core TSLint rule disables... blurgh. Will work on that now. |
|
Wait a minute, dt.json and dtslint.json are empty now. At least the ones in packages/dtslint are. |
I deleted tslint.jsons on DT just now: DefinitelyTyped/DefinitelyTyped#67890 I'm going to heat my office by testing locally while I go make breakfast. |
@JoshuaKGoldberg are you talking about the rules that we deleted without moving to eslint? We triaged the rules into good, bad, decent-but-too-much--effort and only kept the good ones. |
Yeah, once my one comment is fixed, I think this PR is good, so I'm not sure why it's drafted. |
OH! I did a silly and mixed up
Never mind, apologies for the disruption .馃檪 |
"@definitelytyped/header-parser": minor | ||
"@definitelytyped/dtslint": minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I failed to notice that these said minor
. They should have been patch
. We are 0.0.x
without stability and now we just released partial 0.1.0
s :(((((((((((((((
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh geez. sorry!
Fixes #648! 馃コ馃敧
Now that all the old TSLint rules have been switch to ESLint equivalents, there's no more need for TSLint in
dtslint
. This PR removes thetslint
package reference and tooling around it.Edit: Actually, one more set of steps. See #866 (comment).