Fix expectOnly enabling npm-naming #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
expectOnlyis on, we force eslint to only load that one rule, no configs, etc.But, in #681 I forced
npm-namingon via a base config, but forgot to delete that base config inexpectOnly. This had the effect of spurious failures when running unrelated packages asnpm-namingwould be enabled whileuseEslintrcwas disabled, meaning no package's config was being applied.The fix is to reset the config more.
I want to rewrite this to not be so side-effect-y (e.g. add a
getEslintOptionsfunction), but that can come later. Right now, this is just breaking people's PRs.