Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive: "http:" flagged as a variable name #68

Closed
scovetta opened this issue Apr 11, 2019 · 2 comments
Closed

False positive: "http:" flagged as a variable name #68

scovetta opened this issue Apr 11, 2019 · 2 comments
Assignees
Labels
bug rule Something associated with the rules (not code related)

Comments

@scovetta
Copy link
Member

Reported via Twitter:
https://twitter.com/anuraj/status/1107515716800933888

Instead of flagging http:, we should probably include the slashes too. That should cut down a bit on the noise.

@scovetta scovetta added the bug label Apr 11, 2019
@joshbw
Copy link
Contributor

joshbw commented Apr 12, 2019

This was updated ages ago in https://github.com/Microsoft/DevSkim/blob/master/rules/default/security/attack_surface/outbound_network.json - it requires finding http:/ - which plugin is in use? That plugin likely has an outdated rule

@anuraj
Copy link

anuraj commented Apr 17, 2019

I am not using any plugins - default installation I mean. I am using VS 2017 DevSkim extension.

Here is the details of extension.

image

Here is the details of Visual Studio.

image

It is throwing this error for an Angular typescript file.

@gfs gfs added the rule Something associated with the rules (not code related) label Feb 7, 2020
@gfs gfs closed this as completed in bb19b74 Feb 12, 2020
gfs added a commit that referenced this issue Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug rule Something associated with the rules (not code related)
Projects
None yet
Development

No branches or pull requests

5 participants