Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we append server_instance to the Errorlog file names so we can distinguish logs from multiple instances #183

Closed
PiJoCoder opened this issue Jul 6, 2022 · 1 comment
Assignees
Labels
wave 1 - closed consider this issue for next wave of fixes

Comments

@PiJoCoder
Copy link
Collaborator

PiJoCoder commented Jul 6, 2022

This is related to the new get_errorlogs.ps1

Do you want to request a feature or report a bug?
Likely a bug

What is the current behavior?
Need to test with multiple instance of the same version - not sure

*If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem **
Install 2 SQL instances of the same version
Run PSSDIAG using SQL Base collector (on by default) and check the ERRORLOG
files

What is the expected behavior?
To have ERRORLOGs collected from all instances under investigation

Possible solution
Rename the files by appending the servername_instance to the file as we are copying them

PiJoCoder added a commit that referenced this issue Jul 6, 2022
…ent logs

Co-Authored-By: Todd <22751647+gambit9009@users.noreply.github.com>
@PiJoCoder
Copy link
Collaborator Author

FYI @Peter-Msft . We hadn't considered the scenario of multiple instance of the same version. This would take care of it.

@PiJoCoder PiJoCoder added the wave 1 - closed consider this issue for next wave of fixes label Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wave 1 - closed consider this issue for next wave of fixes
Projects
None yet
Development

No branches or pull requests

2 participants