Changed MiniEngine RT sample to work with multiple BLASes #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sample was designed to support multiple BLASes, but it had a bug which probably prevented it from working. All BLAS builds were assigned the same scratch buffer memory, but without a UAV barrier between builds, memory corruption could occur. This was probably avoided by only creating one BLAS. I updated the sample to create a BLAS per mesh and assign each build its own scratch buffer. The alternative was to issue UAV barriers, but this prevents the driver from batching (simultaneous) builds.