[spirv] Add half as allowed (RW)Buffer element type (#1678)

Fixes #1672
microsoft · Nov 8, 2018 · ee00dc1 · ee00dc1
1 parent 2a7c520
commit ee00dc1
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/tools/clang/lib/SPIRV/TypeTranslator.cpp b/tools/clang/lib/SPIRV/TypeTranslator.cpp
@@ -1490,6 +1490,7 @@ TypeTranslator::translateSampledTypeToImageFormat(QualType sampledType) {
                               : elemCount == 2 ? spv::ImageFormat::Rg32ui
                                                : spv::ImageFormat::Rgba32ui;
       case BuiltinType::Float:
+      case BuiltinType::HalfFloat:
         return elemCount == 1 ? spv::ImageFormat::R32f
                               : elemCount == 2 ? spv::ImageFormat::Rg32f
                                                : spv::ImageFormat::Rgba32f;

diff --git a/tools/clang/test/CodeGenSPIRV/type.rwbuffer.half.hlsl b/tools/clang/test/CodeGenSPIRV/type.rwbuffer.half.hlsl
@@ -0,0 +1,13 @@
+// Run: %dxc -T cs_6_0 -E main
+
+// CHECK: %type_buffer_image = OpTypeImage %float Buffer 2 0 0 2 Rgba32f
+// CHECK: %_ptr_UniformConstant_type_buffer_image = OpTypePointer UniformConstant %type_buffer_image
+// CHECK: %HalfBuffer = OpVariable %_ptr_UniformConstant_type_buffer_image UniformConstant
+
+RWBuffer<half4> HalfBuffer;
+
+void main()
+{
+    HalfBuffer[0] = 1.0;
+}
+
diff --git a/tools/clang/unittests/SPIRV/CodeGenSPIRVTest.cpp b/tools/clang/unittests/SPIRV/CodeGenSPIRVTest.cpp
@@ -72,6 +72,9 @@ TEST_F(FileTest, BufferTypeStructError2) {
 TEST_F(FileTest, BufferTypeStructError3) {
   runFileTest("type.buffer.struct.error3.hlsl", Expect::Failure);
 }
+TEST_F(FileTest, RWBufferTypeHalfElementType) {
+  runFileTest("type.rwbuffer.half.hlsl");
+}
 TEST_F(FileTest, RWBufferTypeStructError) {
   runFileTest("type.rwbuffer.struct.error.hlsl", Expect::Failure);
 }