Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPIR-V] Re-enable object debug info #6691

Closed
Keenuts opened this issue Jun 12, 2024 · 1 comment · Fixed by #6696
Closed

[SPIR-V] Re-enable object debug info #6691

Keenuts opened this issue Jun 12, 2024 · 1 comment · Fixed by #6696
Assignees
@Keenuts
Labels
enhancement Feature suggestion spirv Work related to SPIR-V

Comments

@Keenuts
Copy link
Collaborator

Keenuts commented Jun 12, 2024

Now that SPV_KHR_relaxed_extended_instruction is published, we can fix issues like #5218 and #4911 for good.

// RUN: %dxc -T cs_6_0 %s -E main -spirv -fspv-target-env=vulkan1.1 -fspv-debug=vulkan-with-source | FileCheck %s

class A {
  void foo() {
  }
};

[numthreads(1, 1, 1)]
void main() {
  A a;
  a.foo();
}
warning: Member functions will not be linked to their class in the debug information. See https://github.com/KhronosGroup/SPIRV-Registry/issues/203
@Keenuts Keenuts added enhancement Feature suggestion spirv Work related to SPIR-V labels Jun 12, 2024
@Keenuts Keenuts self-assigned this Jun 12, 2024
@Keenuts Keenuts mentioned this issue Jun 12, 2024
Closed
@Keenuts
Copy link
Collaborator Author

Keenuts commented Jun 12, 2024

Waiting on KhronosGroup/SPIRV-Tools#5708

Keenuts added a commit to Keenuts/DirectXShaderCompiler that referenced this issue Jun 14, 2024
@Keenuts
[SPIR-V] Re-enable rich debug instructions for objects
124dd80 
This commit bumps SPIR-V tools version, and re-add support
for objects debug instructions when using Vulkan's debug instructions.

Because OpenCL debug instructions are not a non-semantic set, the
SPIR-V spec would need to be modified, as today it does not allows
forward references.

Fixes microsoft#6691

Signed-off-by: Nathan Gauër <brioche@google.com>
@Keenuts Keenuts mentioned this issue Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Keenuts Keenuts

Labels
enhancement Feature suggestion spirv Work related to SPIR-V
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[SPIR-V] Re-enable rich debug instructions for objects Keenuts/DirectXShaderCompiler
1 participant
@Keenuts