Explicit assign the symbol visibility #1760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This modification is based on https://gcc.gnu.org/wiki/Visibility. In this change, export entries are explicitly marked as default visibility. If put -fvisibility=hidden to CXXFLAGS, dxcompiler binary size reduces for ~25%.
| @@ -13,8 +13,18 @@ | |||
| #ifndef __DXC_API__ | |||
| #define __DXC_API__ | |||
|
|
|||
| #ifndef DXC_API_IMPORT | |||
| #define DXC_API_IMPORT __declspec(dllimport) | |||
| #ifdef _WIN32 | |||
There was a problem hiding this comment.
Don't you need compiler-specific switches here? Do all windows compilers support __declspec(dll*) and all non-windows compilers support __attribute__((visibility))?
There was a problem hiding this comment.
MinGW and clang on Windows also supports __declspec(dll*). So it become a platform thing.
tristanlabelle
approved these changes
Dec 10, 2018
gongminmin
commented
Dec 11, 2018
| @@ -13,8 +13,18 @@ | |||
| #ifndef __DXC_API__ | |||
| #define __DXC_API__ | |||
|
|
|||
| #ifndef DXC_API_IMPORT | |||
| #define DXC_API_IMPORT __declspec(dllimport) | |||
| #ifdef _WIN32 | |||
There was a problem hiding this comment.
MinGW and clang on Windows also supports __declspec(dll*). So it become a platform thing.
|
The full change, including changing the default compiler flags to hidden, was merged as part of #2213. So we can close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modification is based on https://gcc.gnu.org/wiki/Visibility. In this change, export entries are explicitly marked as default visibility. If put -fvisibility=hidden to CXXFLAGS, dxcompiler binary size reduces for ~25%.