Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[linux-port] Fix incorrect UUIDs on Linux #2796

Merged
merged 1 commit into from Mar 30, 2020
Merged

[linux-port] Fix incorrect UUIDs on Linux #2796

merged 1 commit into from Mar 30, 2020

Conversation

nicebyte
Copy link
Contributor

When using libdxcompiler.so, UUIDs of classes don't match
because on Linux a UUID is effectively an address of a
static member variable.

This change replaces UUIDs with a consistent value -
a hash of the class name.

@msftclas
Copy link

msftclas commented Mar 29, 2020 •
edited

CLA assistant check
All CLA requirements met.

@AppVeyorBot
Copy link

✅ Build DirectXShaderCompiler 1.0.2951 completed (commit 9a5128be9d by @nicebyte)

@ehsannas ehsannas self-requested a review March 30, 2020 13:45
@ehsannas ehsannas changed the title Fix incorrect UUIDs on Linux [linux-port] Fix incorrect UUIDs on Linux Mar 30, 2020
@ehsannas ehsannas added the linux Linux-specific work label Mar 30, 2020
ehsannas
ehsannas suggested changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @nicebyte. LGTM. Please run clang-format on this file

@nicebyte
Fix incorrect UUIDs on Linux
a41ab75 
When using libdxcompiler.so, UUIDs of classes don't match
because on Linux a UUID is effectively an address of a
static member variable.

This change replaces UUIDs with a consistent value -
a hash of the class name.
@nicebyte
Copy link
Contributor Author

re-fromatted the file, PTAL. Thanks!

pow2clk
pow2clk approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@pow2clk pow2clk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the headaches that the previous UUID implementation caused me and now I'm kicking myself for not thinking of this! Thanks @nicebyte!

@AppVeyorBot
Copy link

✅ Build DirectXShaderCompiler 1.0.2954 completed (commit 1abf345e19 by @nicebyte)

@nicebyte nicebyte requested a review from ehsannas March 30, 2020 18:30
ehsannas
ehsannas approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@ehsannas ehsannas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ehsannas ehsannas merged commit 34de0e3 into microsoft:master Mar 30, 2020
@ehsannas ehsannas mentioned this pull request May 25, 2020
Closed
@MarijnS95 MarijnS95 mentioned this pull request Aug 2, 2020
Merged
MarijnS95 added a commit to MarijnS95/DirectXShaderCompiler that referenced this pull request Nov 19, 2020
@MarijnS95
Revert "Fix incorrect UUIDs on Linux (microsoft#2796)"
e4cea7a 
This reverts commit 34de0e3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsannas ehsannas ehsannas approved these changes

@pow2clk pow2clk pow2clk approved these changes

Assignees
No one assigned
Labels
linux Linux-specific work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nicebyte @msftclas @AppVeyorBot @ehsannas @pow2clk