Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SPIR-V: Emit RayTmaxKHR builtin for RayTCurrent IOP #3320

Merged
merged 2 commits into from
Dec 17, 2020
Merged

SPIR-V: Emit RayTmaxKHR builtin for RayTCurrent IOP #3320

merged 2 commits into from
Dec 17, 2020

Commits on Dec 15, 2020

  1. SPIR-V: Emit RayTmaxKHR builtin for RayTCurrent IOP 

    HitTKHR was [removed] from the spec as it merely shadows RayTmaxKHR.
Emitting it results in invalid SPIR-V:

    generated SPIR-V is invalid: Operand 3 of Decorate requires one of these capabilities: RayTracingNV
      OpDecorate %6 BuiltIn HitTNV

Replace the builtin by RayTmaxKHR if NV_ray_tracing enabled to resolve
this.

[removed]: KhronosGroup/SPIRV-Headers@bdd2aa3
    @MarijnS95
    MarijnS95 committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    ac9ac09 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2020

  1. test/CodeGenSPIRV: Test RayTCurrent for RayTmax or HitT builtin

    @MarijnS95
    MarijnS95 committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    ff18780 View commit details
    Browse the repository at this point in the history