Fix AV from DxBreak adding branch to null location (unreachable) #4446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeGen for unreachable break would normally skip generation, but DxBreak mechanism would insert conditional branch still. Unreachable location means the builder has no insertion point. This led to null preds for blocks, and an AV in SimplifyCFG. Checking CFG.HaveInsertPoint() is the mechanism used elsewhere to skip CodeGen in unreachable locations, so this is added to EmitHLSLCondBreak.
|
✅ Build DirectXShaderCompiler 1.0.1609 completed (commit bdf6e57d89 by @tex3d) |
pow2clk
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeGen for unreachable break would normally skip generation, but DxBreak
mechanism would insert conditional branch still. Unreachable location
means the builder has no insertion point. This led to null preds for
blocks, and an AV in SimplifyCFG.
Checking CFG.HaveInsertPoint() is the mechanism used elsewhere to skip
CodeGen in unreachable locations, so this is added to EmitHLSLCondBreak.
Fixes #4422