Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make multiline filter first in pipeline #1151

Merged
merged 1 commit into from
Feb 23, 2024
Merged

make multiline filter first in pipeline #1151

merged 1 commit into from
Feb 23, 2024

Conversation

pfrcks
Copy link
Contributor

@pfrcks pfrcks commented Jan 11, 2024 •
edited
Loading

Fluent-bit recommendation for multiline filter ordering

  • Since concatenated records are re-emitted to the head of the Fluent Bit log pipeline, the multiline filter should be the first filter. Logs will be re-emitted by the multiline filter to the head of the pipeline- the filter will ignore its own re-emitted records, but other filters won't. If there are filters before the multiline filter, they will be applied twice. (Refer: https://docs.fluentbit.io/manual/pipeline/filters/multiline-stacktrace)
  • Recommended for performance purposes. Has no functional impact

@pfrcks pfrcks requested a review from a team as a code owner January 11, 2024 02:25
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions GitHub Actions
Copy link

This PR was closed because it has been stalled for 12 days with no activity.

@github-actions github-actions bot closed this Jan 24, 2024
@ganga1980 ganga1980 reopened this Jan 26, 2024
@github-actions GitHub Actions
Copy link

This PR was closed because it has been stalled for 12 days with no activity.

@github-actions github-actions bot closed this Jan 31, 2024
@ganga1980 ganga1980 reopened this Feb 7, 2024
@github-actions GitHub Actions
Copy link

This PR was closed because it has been stalled for 12 days with no activity.

@github-actions github-actions bot closed this Feb 13, 2024
@pfrcks pfrcks reopened this Feb 16, 2024
@pfrcks pfrcks force-pushed the user/amagraw/update-multiline-filter-order branch 2 times, most recently from f01e7e0 to 8cba018 Compare February 21, 2024 17:48
@pfrcks pfrcks force-pushed the user/amagraw/update-multiline-filter-order branch from 8cba018 to f011022 Compare February 21, 2024 21:35
@pfrcks pfrcks merged commit 5f98930 into ci_prod Feb 23, 2024
15 checks passed
@pfrcks pfrcks deleted the user/amagraw/update-multiline-filter-order branch February 23, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jatakiajanvi12 jatakiajanvi12 jatakiajanvi12 approved these changes

@ganga1980 ganga1980 ganga1980 approved these changes

Assignees
No one assigned
Labels
no-pr-activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pfrcks @jatakiajanvi12 @ganga1980