update multiline parser config logic #1180
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
tomlparser.rb
file within thebuild/common/installer/scripts/
directory. The changes focus on modifying the handling of languages supported for multiline logs and stacktraces. The most significant changes involve removingdotnet
from the@stacktraceLanguages
variable and adjusting thepopulateSettingValuesFromConfigMap
method to handledotnet
as a special case.Here are the most important changes in detail:
build/common/installer/scripts/tomlparser.rb
: The@stacktraceLanguages
variable has been updated to removedotnet
and include a comment indicating the supported languages for multiline logs. It's noted thatjava
is also used fordotnet
stacktraces.build/common/installer/scripts/tomlparser.rb
(withindef populateSettingValuesFromConfigMap(parsedConfig)
): The handling ofdotnet
has been adjusted in the method. Ifdotnet
is included in themultilineLanguages
, it's removed andjava
is added to the list, unlessjava
is already included. This change ensures thatdotnet
stacktraces are handled correctly.