Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update multiline parser config logic #1180

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

pfrcks
Copy link
Contributor

@pfrcks pfrcks commented Feb 28, 2024

This pull request includes changes to the tomlparser.rb file within the build/common/installer/scripts/ directory. The changes focus on modifying the handling of languages supported for multiline logs and stacktraces. The most significant changes involve removing dotnet from the @stacktraceLanguages variable and adjusting the populateSettingValuesFromConfigMap method to handle dotnet as a special case.

Here are the most important changes in detail:

  • build/common/installer/scripts/tomlparser.rb: The @stacktraceLanguages variable has been updated to remove dotnet and include a comment indicating the supported languages for multiline logs. It's noted that java is also used for dotnet stacktraces.
  • build/common/installer/scripts/tomlparser.rb (within def populateSettingValuesFromConfigMap(parsedConfig)): The handling of dotnet has been adjusted in the method. If dotnet is included in the multilineLanguages, it's removed and java is added to the list, unless java is already included. This change ensures that dotnet stacktraces are handled correctly.

@pfrcks pfrcks requested a review from a team as a code owner February 28, 2024 02:17
@pfrcks pfrcks changed the title User/amagraw/multiline/update dotnet parser update multiline parser config logic Feb 28, 2024
@pfrcks pfrcks merged commit a50bc72 into ci_prod Feb 28, 2024
15 checks passed
@pfrcks pfrcks deleted the user/amagraw/multiline/update-dotnet-parser branch February 28, 2024 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants