Gangams/expose disable telemetry config option #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfrcks
reviewed
Mar 2, 2024
build/common/installer/scripts/tomlparser-common-agent-config.rb
Outdated
Show resolved
Hide resolved
build/common/installer/scripts/tomlparser-common-agent-config.rb
Outdated
Show resolved
Hide resolved
pfrcks
reviewed
Mar 2, 2024
pfrcks
approved these changes
Mar 2, 2024
jatakiajanvi12
pushed a commit
that referenced
this pull request
Apr 15, 2024
* config option for telemetry disablement * Update .trivyignore * changes related to disable telemetry config option * fix pr feedback * clean up comment * refactor code
jatakiajanvi12
pushed a commit
that referenced
this pull request
Apr 15, 2024
* config option for telemetry disablement * Update .trivyignore * changes related to disable telemetry config option * fix pr feedback * clean up comment * refactor code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new config option to disable agent telemetry collection.
Major changes:
Script addition and integration:
build/common/installer/scripts/tomlparser-common-agent-config.rb: A new Ruby script was added that parses a config map to set environment variables related to agent settings. It includes functionality to validate numeric values and wait times, parse the config map, and write the settings to a file.build/linux/installer/datafiles/base_container.data: The new Ruby script was added to the base container data file, ensuring it is included in the built container.kubernetes/linux/main.sh: The main script for Linux was updated to call the new Ruby script and source the environment variables it sets.kubernetes/windows/main.ps1: The main script for Windows was also updated to call the new Ruby script and set the environment variables it defines.Config map changes:
kubernetes/container-azm-ms-agentconfig.yaml: The Kubernetes config map file was updated to include a new, undocumented setting related to telemetry underagent_settings.telemetry_config.